Fixed notify happening before association is added to accept queue #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The association is not added to the accept queue until after the COMM_UP notification is triggered. This causes the application to have to wait an indeterminate amount of time and can cause race conditions when the application calls accept before usrSCTP adds the association to the accept queue.
|
Could you provide a minimal test program which doesn't work before you change and does work after it? |
|
I'm working on something else currently, but if I can find some time I'll do that. Not sure how long that'll be though. |
|
Hi @tuexen ... Apologies for the delay. I've created an example using the ekr example program. unzip and replace ekr_server.c, and run the server and client as normal. With the sleep, it spams the console with "usrsctp_accept: Resource temporarily unavailable" until the function returns and adds the association to the accept queue. Without the sleep, it depends on when the OS schedules the main thread to run - sometimes it fails until the second try, sometimes it works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the server socket is operating in non-blocking mode, we wait for
the COMM_UP notification, and then call accept. However, the
association is not added to the accept queue until after the COMM_UP
notification is triggered. This causes the application to have to wait an
indeterminate amount of time and can cause race conditions when the
application calls accept before usrSCTP adds the association to the
accept queue.